Rename basin/control thresholds to wiki naming; trim stale comments

Aligns the code with the 5-threshold convention used throughout the
wiki (basin model + per-mode transfer-function diagrams):

  heightInlet       → inflowLevel
  heightOutlet      → outflowLevel
  heightOverflow    → overflowLevel
  stopLevel         → minLevel
  maxFlowLevel      → maxLevel
  minFlowLevel      → removed (collapsed into startLevel; they were
                      always supposed to hold the same value)
  minVolIn          → minVolAtInflow
  minVolOut         → minVolAtOutflow
  maxVolOverflow    → maxVolAtOverflow
  startLevel        → unchanged

Config schema (generalFunctions/src/configs/pumpingStation.json) is
updated in a parallel commit in that submodule.

Also:
- Stripped the ~150-line ASCII basin diagram from initBasinProperties
  JSDoc; it now points at wiki/functional-description.md#basin-model.
- Trimmed the top-of-class JSDoc — the config-sections breakdown was
  drifting from the schema anyway; wiki is now the source of truth.
- Tidied inline comments in _controlLevelBased, _scaleLevelToFlowPercent.
- Editor order reshuffled to match the bottom→top basin order:
  minLevel, startLevel, maxLevel.

Breaking change for saved flows: existing pumpingStation nodes in
production flows reference the old field names and will need to be
re-entered in the editor. No compat shim — node is RnD/trial.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

src/nodeClass.js

@@ -44,9 +44,9 @@ class nodeClass {
       basin: {
         volume: uiConfig.basinVolume,
         height: uiConfig.basinHeight,
-        heightInlet: uiConfig.heightInlet,
-        heightOutlet: uiConfig.heightOutlet,
-        heightOverflow: uiConfig.heightOverflow,
+        inflowLevel: uiConfig.inflowLevel,
+        outflowLevel: uiConfig.outflowLevel,
+        overflowLevel: uiConfig.overflowLevel,
       },
       hydraulics: {
         refHeight: uiConfig.refHeight,
@@ -56,10 +56,9 @@ class nodeClass {
       control:{
         mode: uiConfig.controlMode,
         levelbased:{
+          minLevel:uiConfig.minLevel,
           startLevel:uiConfig.startLevel,
-          stopLevel:uiConfig.stopLevel,
-          minFlowLevel:uiConfig.minFlowLevel,
-          maxFlowLevel:uiConfig.maxFlowLevel
+          maxLevel:uiConfig.maxLevel
         }
       },
       safety:{
@@ -118,7 +117,7 @@ class nodeClass {
     const level = pickVariant('level', ['measured', 'predicted'], 'atEquipment', 'm');
     const netFlow = pickVariant('netFlowRate', ['measured', 'predicted'], 'atEquipment', 'm3/h');
 
-    const maxVolBeforeOverflow = ps.basin?.maxVolOverflow ?? ps.basin?.maxVol ?? 0;
+    const maxVolBeforeOverflow = ps.basin?.maxVolAtOverflow ?? ps.basin?.maxVol ?? 0;
     const currentVolume = vol.value ?? 0;
     const currentvolPercent = volPercent.value ?? 0;
     const netFlowM3h = netFlow.value ?? 0;
@@ -254,6 +253,7 @@ class nodeClass {
     this.node.on('close', (done) => {
       clearInterval(this._tickInterval);
       clearInterval(this._statusInterval);
+      this.node.status({});  // clear node status badge
       done();
     });
   }