619b1311d2
src/groupOps/ groupOperatingPoint + groupCurves (pure functions)
src/totals/ totalsCalculator (dynamic + absolute + active)
src/combinatorics/ pumpCombinations (validPumpCombinations + checkSpecialCases)
src/optimizer/ bestCombination (CoG) + bepGravitation (BEP-G + marginal-cost)
src/efficiency/ groupEfficiency (calc + distance helpers)
src/dispatch/ demandDispatcher (LatestWinsGate-based; replaces
_dispatchInFlight + _delayedCall)
src/commands/ canonical names from start (set.mode/scaling/demand,
child.register) + legacy aliases
CONTRACT.md inputs/outputs/events surface
53 basic tests pass (52 new + 1 pre-existing).
specificClass.js / nodeClass.js untouched — integration in P4 wave 2.
Findings flagged via agents (TODO append to OPEN_QUESTIONS.md):
- calcGroupEfficiency.maxEfficiency is actually the mean (misleading name)
- checkSpecialCases has a no-op `return false` inside forEach
- MGC doesn't route cmd.startup/shutdown/estop — confirm if station broadcasts need it
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
28 lines
1.0 KiB
JavaScript
28 lines
1.0 KiB
JavaScript
// Group-scope read helpers for pump curves.
|
|
//
|
|
// Optimizers and totals evaluate each pump at the GROUP operating point
|
|
// (set by GroupOperatingPoint.equalize), not the pump's individual sensor-
|
|
// driven point. Each pump exposes a parallel "group*" predict object —
|
|
// these helpers fall back to the individual predicts when the pump hasn't
|
|
// been initialised for group operation yet (first tick after register).
|
|
|
|
function groupFlow(machine /*, ctx */) {
|
|
return machine.groupPredictFlow ?? machine.predictFlow;
|
|
}
|
|
|
|
function groupPower(machine /*, ctx */) {
|
|
return machine.groupPredictPower ?? machine.predictPower;
|
|
}
|
|
|
|
function groupNCog(machine /*, ctx */) {
|
|
return machine.groupPredictFlow ? (machine.groupNCog ?? 0) : (machine.NCog ?? 0);
|
|
}
|
|
|
|
function groupCalcPower(machine, flow /*, ctx */) {
|
|
return typeof machine.groupCalcPower === 'function'
|
|
? machine.groupCalcPower(flow)
|
|
: machine.inputFlowCalcPower(flow);
|
|
}
|
|
|
|
module.exports = { groupFlow, groupPower, groupNCog, groupCalcPower };
|