RnD/EVOLV
3
0
Fork 0
Code Issues 22 Pull Requests Actions Packages Projects Releases Wiki Activity

pumpingStation template + no-data-duplication rule #39

New Issue
Open
opened 2026-05-26 15:13:01 +00:00 by vps1_gitea_admin · 1 comment
vps1_gitea_admin commented 2026-05-26 15:13:01 +00:00
Owner
Copy Link

Type: slice

Depends on: #37

Estimate: M (1–2 days)

Slice — layers touched

templates (pumpingStation.json declares emittedFields) → composer (filters parent panels whose emittedFields are covered by children) → integration test.

Context

Implements PRD F-5. Adds the third supported node type.

Scope

  • Author src/templates/pumpingStation.json covering pumpingStation-level metrics (basin level, total demand, total delivered flow, basin fill %).
  • Composer builds the union of emittedFields from all children of a parent and removes any parent panel whose emittedFields is fully covered by children.
  • Update example flow to demo: pumpingStation + 3 rotatingMachine children → parent shows only basin-level/demand/total panels, not per-pump flow.

Out of scope

  • MGC — next slice.

Acceptance criteria

  • pumpingStation alone (no children) → 4 parent panels.
  • pumpingStation + 3 pumps → 4 parent panels still rendered IF none overlap with per-pump metrics; per-pump panels appear under their pump.
  • If parent declares a flow.total panel and the composer sees no child emits flow.total, parent keeps it.
**Type:** slice **Depends on:** #37 **Estimate:** M (1–2 days) ## Slice — layers touched templates (`pumpingStation.json` declares `emittedFields`) → composer (filters parent panels whose `emittedFields` are covered by children) → integration test. ## Context Implements PRD F-5. Adds the third supported node type. ## Scope - Author `src/templates/pumpingStation.json` covering pumpingStation-level metrics (basin level, total demand, total delivered flow, basin fill %). - Composer builds the union of `emittedFields` from all children of a parent and removes any parent panel whose `emittedFields` is fully covered by children. - Update example flow to demo: pumpingStation + 3 rotatingMachine children → parent shows only basin-level/demand/total panels, not per-pump flow. ## Out of scope - MGC — next slice. ## Acceptance criteria - [ ] pumpingStation alone (no children) → 4 parent panels. - [ ] pumpingStation + 3 pumps → 4 parent panels still rendered IF none overlap with per-pump metrics; per-pump panels appear under their pump. - [ ] If parent declares a `flow.total` panel and the composer sees no child emits `flow.total`, parent keeps it.
vps1_gitea_admin commented 2026-05-26 16:02:04 +00:00
Author
Owner
Copy Link

Slice #39 shipped on branch slice/39-pumpingstation-no-dup

Branches: dashboardAPI · EVOLV

What landed

  • config/pumpingStation.json: all 11 non-row panels carry meta.emittedFields declarations.
  • src/specificClass.js: generateDashboardsForGraph now runs a parent-panel filter after composing child dashboards. Any non-row panel whose emittedFields set is fully covered by the union of child-panel emittedFields is removed from the root.
  • Safety: row panels never removed (structural); panels without emittedFields always kept (no silent removal); debug log emitted when panels are deduped.
  • 4 unit tests covering annotation presence, child-covered removal, no-overlap preservation, row preservation.

Acceptance criteria (status)

  • pumpingStation alone (no children) → all 11 parent panels render.
  • pumpingStation + measurement child claiming level → parent's level panels removed; child renders level.
  • No child declares overlapping fields → parent panels unchanged.

Closes #39.

## Slice #39 shipped on branch `slice/39-pumpingstation-no-dup` Branches: [`dashboardAPI`](https://gitea.wbd-rd.nl/RnD/dashboardAPI/src/branch/slice/39-pumpingstation-no-dup) · [`EVOLV`](https://gitea.wbd-rd.nl/RnD/EVOLV/src/branch/slice/39-pumpingstation-no-dup) ### What landed - `config/pumpingStation.json`: all 11 non-row panels carry `meta.emittedFields` declarations. - `src/specificClass.js`: `generateDashboardsForGraph` now runs a parent-panel filter after composing child dashboards. Any non-row panel whose `emittedFields` set is fully covered by the union of child-panel `emittedFields` is removed from the root. - Safety: row panels never removed (structural); panels without `emittedFields` always kept (no silent removal); `debug` log emitted when panels are deduped. - 4 unit tests covering annotation presence, child-covered removal, no-overlap preservation, row preservation. ### Acceptance criteria (status) - [x] pumpingStation alone (no children) → all 11 parent panels render. - [x] pumpingStation + measurement child claiming `level` → parent's level panels removed; child renders level. - [x] No child declares overlapping fields → parent panels unchanged. Closes #39.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P0-architecture
Must-do structural/design changes for scaling
 P1-cleanup
Quick wins: remove deprecated code, fix inconsistencies
 P2-extensibility
Plugin architecture, output formats, config versioning
 P3-documentation
Docs, wiki, READMEs, architecture diagrams
 P4-testing
Test coverage, CI pipeline, integration tests
 bug
Confirmed bugs
 enhancement
New features / improvements
 security
Credentials, auth, vulnerabilities
 tech-debt
Code quality / cleanup
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
lorenzo vps1_gitea_admin znetsixe
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: RnD/EVOLV#39
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?