Two cross-submodule fixes for the reactor unit-confusion drift the wiki
uplift surfaced:
- nodes/generalFunctions @ 4f715e8: reactor schema timeStep.unit now "s"
(was "h"), default 1 (was 0.001). Matches reactor.html label [s] and
baseEngine.js's seconds→days conversion. Description warns future
readers off changing the unit without updating the engine.
- nodes/reactor @ 346a3ce: HTML X_A_init default 0.001 → 200 (operational
nitrifying biomass; 0.001 disabled nitrification per the memory note).
Factory updated to match. New regression test
test/basic/timestep-units.basic.test.js locks in the seconds contract
and schema agreement. 49/49 reactor tests pass.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- tools/physics-sanity/ — JS library of cross-node balance helpers
(mass / hydraulic / hydraulic-power / oxygen-transfer / energy) with
7 unit tests + a CLI demo. Designed for `require()` from per-node
integration tests where shape-based unit tests miss physically-
impossible plant states.
- tools/docker-compose.yml + tools/mcp/{node-red-admin,influxdb,browser}
scaffolding — placeholder Dockerfiles + a ROADMAP.md for the Node-RED
admin MCP. Compose file is the target shape for the Q3-2026 migration
to the central MCP server; the per-service Dockerfile stays in this
repo as the canonical definition either way. Implementations are TODO.
- tools/README.md — top-level tooling index; documents the CI order for
running every tool on a PR.
- .gitignore: ignore tools/.env (developer-specific MCP endpoints).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- tools/output-manifest-verify/ — enforces .claude/rules/output-coverage.md
§3: every node ships test/_output-manifest.md and every declared key
is referenced by at least one test file. First run shows only
machineGroupControl has the manifest (16 keys covered); all other nodes
warn. --strict escalates "missing manifest" to an error for CI gating.
- flow-lint gains two rules from the same output-coverage rule:
* FN_OUTPUT_WIRES_MISMATCH — function declares outputs=N but wires has
M arrays (causes silent dropped or duplicate emissions).
* FN_PAYLOAD_NULL_LITERAL — function source contains `payload: null`
literal (the η-null ui-chart crash pattern from 2026-05-14).
First run found 1 instance in mgc/02-Dashboard.json.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces the placeholder topic tables in Reference-Contracts.md (left by
the wiki uplift agents) with authoritative content generated from each
node's src/commands/index.js. CI gate: `node tools/wiki-gen/bin/wiki-gen.js --check`.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Generates the markdown table inside <!-- BEGIN AUTOGEN: topic-contract -->
blocks in nodes/<n>/wiki/Reference-Contracts.md from the canonical registry
at src/commands/index.js. Replaces the agent-written placeholders the wiki
uplift left behind.
- Accepts both labelled and unlabelled END markers; rewrites to canonical
'<!-- END AUTOGEN: topic-contract -->' on regeneration so future runs are
consistent.
- --check mode for CI (exit 1 if any block is out of date).
- Out of scope for now: data-model AUTOGEN block (requires instantiating
the domain; the 9 agent-written placeholders for that block stay until
a follow-up tool lands).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Each node's wiki now matches the rotatingMachine reference: Home +
Reference-{Architecture,Contracts,Examples,Limitations} + _Sidebar.
Total ≈ 9 000 lines of wiki content. Topic-contract and data-model
sections wrapped in <!-- BEGIN AUTOGEN --> markers for the future
wiki-gen tool.
Each agent surfaced real source-vs-spec drift rather than inventing
content:
- measurement: digital-mode notifyOutputChanged path uncertain;
buildDomainConfig drops several editor fields; position case
preserved by child.register payload
- valve: flowController gates by source only (action allow-list dead);
no enter/exit maintenance sequences; sequence-abort token status TBD
- reactor: timeStep unit confusion (HTML s, schema h, engine /86400);
X_A default disagreement (0.001 vs 200 mg/L); doesn't honour the
canonical-unit rule (m³/d not m³/s, °C not K)
- valveGroupControl: 4 CONTRACT/source drifts incl. set.mode covers
4 modes not 2, calculationMode + mode.allowedActions dead config,
maintenance source allow-list undefined
- settler: icon colour #e4a363 conflicts S88 Unit #50a8d9; Port 2
emits null in _emitOutputs (init-only registration)
- diffuser: stale test/README claiming "no runtime" — runtime exists
(284-line specificClass with full OTR/ΔP model); update README
- monster: superproject docs frame as multi-parameter biological
monitor (NH4/NO3/COD/TSS), but source emits only volumetric pulse +
bucket state; 4 example flows referenced but missing on disk
- dashboardAPI: dashboardapi.{js,html} lowercase entry vs folder
convention; logging.enabled default mismatch (false vs true)
- generalFunctions: full library API restructure preserved; module
map + consumer graph + extension examples retained
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- tools/contract-verify/ — diffs CONTRACT.md ## Inputs table vs
src/commands/index.js registry. First run found 3 real drifts:
MGC has `set.scaling` in CONTRACT (not in registry); monster + settler
registry has `child.register` (not in CONTRACT); pumpingStation registry
has `set.outflow` (not in CONTRACT).
- tools/flow-lint/ — lints examples/*.flow.json against the rules in
.claude/rules/node-red-flow-layout.md. First run flagged the
monster/basic flow (4 ui-* at 0,0 + ui-chart missing interpolation
property) and rotatingMachine/edge.flow.json (6 ui-* at 0,0).
- Both tools are read-only, single-binary npm packages with a `--json`
output mode for CI, exit code 1 on drift. Encode the rules so we
don't have to re-discover the bugs that motivated them.
Per CLAUDE.md tooling doctrine: prefer these over ad-hoc grep/jq.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Delete .mcp.json + .claude/rules/repo-mem.md; drop .repo-mem from .gitignore
- Remove repo-mem / substrate_score / repo_search references from all .md
- Move 15 EVOLV skills from .agents/skills/ to .claude/skills/ so they are
auto-discovered by the Claude Code harness and invokable via the Skill tool
- Retire .agents/skills/evolv-orchestrator (duplicate of the subagent at
.claude/agents/evolv-orchestrator.md); orchestrator lives as a subagent only
- Drop OpenAI-format agent yaml metadata from each skill (not needed for CC)
- Update CLAUDE.md, CONTRACTS.md, AGENTS.md to point at the new locations and
disambiguate skills (.claude/skills/) vs subagents (.claude/agents/)
- Fix CLAUDE.md tick-loop wording (opt-in per-node, not a fixed 1000ms)
- Widen .claude/rules/ paths frontmatter so node-architecture and telemetry
rules trigger on more relevant files; add frontmatter to flow-layout rule
- Bump CONTRACTS.md review date to 2026-05-19; add step 7 to the contract-
change workflow (review example flows when topic usage changes)
- Bump nodes/generalFunctions pin (Home.md substrate_score reference removed)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Establish CONTRACTS.md at the EVOLV root as the canonical map of where every
contract, rule, and standard lives. Surface it from CLAUDE.md so every fresh
agent or colleague lands there first.
Reshape .claude/refactor/ to reflect that the platform refactor is done:
live standards stay at the top level; the plan artifacts (CONTINUE_HERE.md,
TASKS.md) move into Archive/ with WARNING banners.
Drop content that drifted out of date or duplicated the new standards stack:
- docs/DEVELOPER_GUIDE.md (pre-refactor walkthrough; superseded by
wiki/Architecture, wiki/Getting-Started, .claude/rules/node-architecture,
.claude/refactor/MODULE_SPLIT + per-node CONTRACT.md + src/commands/).
- .agents/decisions/ (15 DECISION files): load-bearing decisions belong in
commit messages and PR descriptions; live open items in OPEN_QUESTIONS.md.
- .agents/improvements/TOP10_*.md: moved to Archive/.
Bump generalFunctions to 49c77f2 — adds CONTRACT.md inside the library:
different shape from per-node CONTRACT.md files (library API, not msg.topic),
with stability tags and pointers to .claude/refactor/CONTRACTS.md §N.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* generalFunctions @ 34a4ef0 — new iconHelpers module + initVisuals
step on logger/position menus; asset selector rebuilt as a chip
wizard with per-stage type-to-filter combobox and node-aware curve
mini-chart (rotatingMachine Q-H, valve Cv, diffuser SOTE).
* machineGroupControl @ 6833e9f — consumes the shared visuals;
strategy/rendezvous cards keep their MGC-local SVGs; maintenance
switched to FA fa-wrench. Output-format pickers now use the shared
.evolv-icon-picker classes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- machineGroupControl @ 472402c — rendezvous planner extracted into
src/movement/. Every dispatch (both optimalControl and priorityControl)
routes through a shared _dispatchFlowDistribution helper so all pumps
reach their setpoint at t* = max(eta_i) regardless of per-pump speed.
New "Same-time landing" toggle in the editor (planner.useRendezvous,
default true) for operators who want the legacy fire-and-forget.
- generalFunctions @ af02d36 — new planner.useRendezvous schema field
and stateManager.getRemainingTransitionS() that the planner reads to
compute exact eta for children mid-ladder.
- rotatingMachine @ 5ea0b0b — sequenceController honors the new
sequenceAbortToken so a pre-empted sequence (e.g. shutdown caught
mid-ramp by a fresh demand) cleanly breaks out instead of barging
through to its terminal state.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- generalFunctions f8f71a4: schema additions (output.process/dbase,
functionality.distance, drop prioritypercentagecontrol), measurement
position.x nullable, asset-data file renamed machine.json ->
rotatingmachine.json so AssetMenu lookup matches, menu re-derives
supplier/assetType from saved model id on reopen.
- pumpingStation 2c7fe17: setDemand reads unit-normalised payload from
commandRegistry (mirrors today's MGC change to unit-self-describing
demand commands). Pre-existing test failure (stale path to
basic-dashboard.flow.json, renamed to 02-Dashboard.json in fe5fa35) is
unrelated to this commit.
- rotatingMachine 394a972: η = (Q·ΔP)/P_shaft replaces the legacy Q/P
formula — gives a real BEP peak so NCog stops collapsing to 0 and the
MGC dashboard's BEP-position metric actually moves. Asset-registry
lookup renamed machine -> rotatingmachine (matches generalFunctions
rename). Constructor stateConfig pass-through fixed (default-param was
clobbering BaseNodeAdapter's pre-set extras). + 2 new tests.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
MGC submodule lands the 2026-05-14 governance review fixes plus rolled-up
session work: _output-manifest.md per the new output-coverage rule,
computeEqualFlowDistribution extracted as a pure function (testable without
MGC), groupEfficiency degenerate-case fix, unit-self-describing set.demand,
eta = (Q*dP)/P formula correction, and dashboard fan-out hardening
(auto-init, NCog normalization, Q-H trim, null-trap closure). Suite 108/108.
Superproject adds:
- .claude/rules/output-coverage.md: every-output-every-state testing rule
prompted by the eta-null crash earlier in the session.
- CLAUDE.md: pointer to the new rule under Conventions.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Follow-up to the AssetResolver landing. All five diffuser supplier
curves now share one X-axis convention; diffuser specificClass
computes specific flux from total flow + membrane area and queries the
curves at that flux. Each curve file carries its own
_meta.membraneArea_m2_per_element so the node defaults are correct
without any per-node overrides.
Supplier naming fixed: Sulzer (PIK300/PRK300), Aquaconsult-Entec
(Aerostrip Phoenix).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Coordinated cutover across five submodules to the generalFunctions
asset registry. Highlights:
- generalFunctions: AssetResolver namespace + FileBackend, with new
diffuser supplier curves (GVA migrated, Jäger JetFlex EPDM-1000,
Aerostrip Phoenix multi-coverage, PIK300/PRK300 multi-coverage).
Diffuser config schema corrected: density was always meant to be
bottom-coverage %, not elements/m².
- diffuser: _loadSpecs reads from the registry; editor wired with the
shared asset cascade (supplier → type → model → unit).
- rotatingMachine + valve: derive supplier/type/units from the model
id via resolveAssetMetadata; reject saved legacy fields with a clear
re-save prompt.
- machineGroupControl: integration fixtures use the trimmed asset
shape.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Surfaces mode/scaling in the editor, fixes the camelCase-vs-lowercase
mismatch that silently disabled dispatch on default config, compacts the
status badge, extends getOutput with capacity / machine-count fields, and
replaces the pre-refactor example stubs with 01-Basic.json (MGC + 3
pumps + setup) and 02-Dashboard.json (FlowFuse dashboard with charts).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Fixes MGC child-registration id collision and rotatingMachine
curve-lookup failure caused by the shallow Object.assign in
ConfigManager.buildConfig wiping general.id and asset.model.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Includes 285fd01 (drop 52 MB 01-basic-demo.gif) and 6e89e49 (restore GIF
"needed" placeholders in Home and Reference-Examples so the dropped media
is tracked instead of leaving a broken image link).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Submodule pointers
- pumpingStation: realistic basin defaults, ramp-foot visual fix, manual-mode
observability, new 02-Dashboard.json (charts + raw-output table), wiki
Home/Reference-Examples with screenshots + demo GIF.
- generalFunctions: pumpingStation config schema defaults aligned with the
new editor drag-in values; startLevel description corrected (ramp foot is
inflowLevel, not startLevel).
- monster: examples cleanup — drop pre-refactor flows, ship single
02-integrated-e2e.json.
Wiki
- New wiki/Functional-Overview.md: companion to Architecture covering the
process side — what each node physically represents and which control
objective it serves.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pilot pass for the per-node Home redesign. pumpingStation's wiki/
now has a short, intuitive Home.md plus four Reference-* sibling
pages (Contracts / Architecture / Examples / Limitations). Asset
placeholders created under wiki/_partial-{screenshots,gifs,flows}/
with explicit "screenshot needed" / "GIF needed" callouts where
the user will record assets.
Abandoned content: wiki/functional-description.md and wiki/modes/*
were removed from source per user direction (example-driven over
prose).
Once this pattern is validated on the live pumpingStation wiki,
the same split will be applied to the other 10 nodes.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Source-tree mirror of EVOLV.wiki.git refactor (27a42ee on wiki.git):
- 7 master pages rewritten with clean design (Home, Architecture,
Topology-Patterns, Topic-Conventions, Telemetry, Getting-Started,
Glossary). Tables and Mermaid for visuals, gitea alert callouts for
warnings, shields badges for metadata only. No emoji as decoration.
- Archive.md becomes a removal-changelog pointing readers to git
history and to the successor pages.
- _Sidebar.md updated to navigate the new flat-name layout.
- Concept / finding / manual pages: uniform mini-header (badges +
"reference page" callout) added without rewriting domain content.
- Every internal link now uses the flat naming that resolves on the
live gitea wiki (Concept-ASM-Models, Finding-BEP-..., etc.).
On wiki.git: 29 Archive-* pages hard-deleted (the git history
preserves them; Archive.md documents the removal).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
CONTRACTS.md §4: full payloadSchema.type table including 'none', plus
the optional description field example. Matches the B3.2 implementation.
WIKI_TEMPLATE.md §5: Unit column appears with explanatory paragraph.
Matches the P11.4 wikiGen output.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Single doc capturing the 'what's not done' at the end of the
2026-05-11 sprint, in priority order: B5 reactor boundary-conditions
merge, Phase 8 PR cycle, a handful of small open-questions follow-ups,
plus the wiki cosmetics list. README.md links to it from the top.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
All 11 nodes' wiki/Home.md regenerated with the Unit column +
per-topic descriptions. rotatingMachine + reactor private-method
test files rewritten to the public BaseNodeAdapter surface.
OPEN_QUESTIONS: rotatingMachine + reactor private-test entries
marked RESOLVED.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The original Dockerfile switched to USER node-red before WORKDIR
/data/evolv, so the auto-created parent directory ended up root-owned
and `RUN npm install` failed with EACCES trying to mkdir node_modules.
Fix: mkdir + chown explicitly as root, then WORKDIR + USER node-red.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
scripts/test-platform.js iterates each submodule, runs npm test, shows
a per-node pass/fail summary, exits non-zero if any node fails.
Wired as `npm run test:platform` in the parent package.json.
Submodule pointer bumps:
dashboardAPI 2874608 → 92d7eba (Mocha → node:test conversion for edge+integration)
diffuser 0ec9dd1 → 15cfb22 (P10.7a test script fix)
generalFunctions 8ebf31d → 95c5e68 (P10.7a test script fix + remove 5 broken Mocha dupes)
pumpingStation 52d3889 → d2384b1 (P10.7a test script fix)
Current platform-wide gate: 729 pass / 5 fail across 12 submodules
(5 failures are all pre-existing AssertionErrors logged in
OPEN_QUESTIONS.md for Phase 10.5).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WIKI_TEMPLATE.md — extend the canonical per-node page from 9 to 14 sections:
+ Header band (commit hash + regen date)
+ Code map (flowchart TB w/ subgraphs over concern modules)
+ Child registration (mirrors ChildRouter declarations)
+ Data model — getOutput() (abstract schema + optional concrete sample)
+ Debug recipes (symptom → first thing to check)
+ AUTOGEN markers around topic-contract + data-model schema so the
Phase 9 regen script can rewrite in place.
+ 'Picking a visual' table: Mermaid is default, plots/SVG/screenshots
allowed where they serve the data.
+ Archive banner snippet.
WIKI_HOME_TEMPLATE.md (new) — Home.md + Archive.md templates:
- Platform-wide Mermaid graph of 11 active nodes, S88-coloured.
- Navigation table grouped by S88 level.
- Standards-pointer table to .claude/rules + .claude/refactor docs.
- Live refactor-status table for returning visitors.
- Archive index template with archival-date column.
No wiki pages written yet — next step is one worked example
(pumpingStation) before any change to the Gitea wiki repo.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Defines the 9-section template every node's wiki page follows:
1. Position in the platform (mermaid flowchart, S88-coloured)
2. Capability matrix (≤ 10 rows)
3. Topic contract (auto-generated from src/commands/index.js)
4. Lifecycle (mermaid sequenceDiagram)
5. Configuration (mermaid flowchart + form-to-config table)
6. Examples (basic/integration/dashboard tiers)
7. State chart (stateDiagram-v2, only for stateful nodes)
8. When you would NOT use this node
9. Known limitations / current issues
Hard rules: diagrams before prose, ≤ 60 words of unbroken prose
anywhere, topic contract auto-generated (no hand-written drift).
Per-node application is the next step (P9.3-P9.6 in TASKS.md).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Resolves the 5 open questions answered during Phase 1 setup:
- Topic naming: canonical from Phase 1 (set/cmd/data/child/query/evt),
with full glossary in CONTRACTS.md §1.
- Parent EVOLV branch lineage: rebased onto origin/main.
- Deprecated paths: tracked as Phase 8.5 in TASKS.md.
- Child storage: registry-as-truth + named getters via
declareChildGetter.
- Tick: opt-in via static tickInterval; default is event-driven via
source.emitter 'output-changed'. statusInterval (always-on, 1Hz)
is separate.
Plus two new pre-existing-issue notes from the sanity gate:
- dashboardAPI uses Mocha-style describe() under node:test (broken).
- reactor tests are mathjs-bound (~13s/file load).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Platform-wide refactor plan: README, CONVENTIONS, CONTRACTS,
MODULE_SPLIT, TASKS, OPEN_QUESTIONS. Source of truth for the
phased refactor across all 12 submodules.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pump-shutdown deadlock fix split across two submodules:
- rotatingMachine@8f9150e: shutdown sequence clears state.delayedMove
so the abort-and-return-to-operational path doesn't auto-pickup the
queued setpoint and re-engage the pump.
- machineGroupControl@ea2857f: turnOffAllMachines clears MGC's
_delayedCall and serializes per-pump shutdown so PS's 2 s tick loop
can't interrupt an in-flight shutdown.
Live verification on pumpingstation-complete-example demo: basin now
shuts pumps off at stopLevel cleanly, reverses to fill, completes the
hysteresis cycle.
Also disable the trends page in the demo flow (build_flow.py + regen
flow.json). FlowFuse ui-chart's per-series server-side history buffer
(7 charts × ~20 series × 3600-point retention) was saturating the
Node-RED event loop at 129% CPU, making the dashboard freeze on every
click. Trends remain available — just disabled by default; flip the
ui_page_trends "d" key to false to re-enable.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WARN now fires only when force-aborting an actually in-flight pump
movement (gate-bypass safety net), not on every no-op tick.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds the _dispatchInFlight gate that mirrors rotatingMachine
state.delayedMove. Before this, PS at 1 Hz overran in-flight pump
ramps via concurrent handleInput entries, producing the live thrash:
120 aborts / 2 min, pump_b clamped at minFlow.
Includes regression test:
test/mgc-overactive-demand-serialization.integration.test.js
covering concurrent-burst serialization (30 calls → ≤ 5 aborts) and
latest-wins semantic.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
